Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix nightly build #8142

Merged
merged 2 commits into from
Jul 9, 2024
Merged

chore: fix nightly build #8142

merged 2 commits into from
Jul 9, 2024

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Jun 24, 2024

Problem

cargo +nightly check fails

Summary of changes

Updates measured, time, and crc32c.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner June 24, 2024 13:32
Copy link

github-actions bot commented Jun 24, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_isolation[None]: debug

Postgres 15

  • test_storage_controller_heartbeats[failure2]: release

Code coverage* (full report)

  • functions: 32.6% (6941 of 21283 functions)
  • lines: 50.0% (54562 of 109072 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
36a768e at 2024-07-09T16:12:54.815Z :recycle:

@conradludgate conradludgate enabled auto-merge (squash) July 9, 2024 15:08
@conradludgate conradludgate merged commit 4a5b55c into main Jul 9, 2024
65 checks passed
@conradludgate conradludgate deleted the fix-nightly-2024-june branch July 9, 2024 17:25
skyzh pushed a commit that referenced this pull request Jul 15, 2024
## Problem

`cargo +nightly check` fails

## Summary of changes

Updates `measured`, `time`, and `crc32c`.

* `measured`: updated to fix
rust-lang/rust#125763.
* `time`: updated to fix rust-lang/rust#125319
* `crc32c`: updated to remove some nightly feature detection with a
removed nightly feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conflicting impl since nightly-2024-05-01 Type inference regression on nightly-2024-05-20
4 participants