Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strocon: don't overcommit when making node fill plan #8171

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

VladLazar
Copy link
Contributor

Problem

The fill requirement was not taken into account when looking through the shards of a given node to fill from.

Summary of Changes

Ensure that we do not fill a node past the recommendation from Scheduler::compute_fill_requirement.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Problem
The fill requirement was not taken into account when looking
through the shards of a given node to fill from.

Summary of Changes:
Ensure that we do not fill a node past the recommendation from
`Scheduler::compute_fill_requirement`.
@VladLazar VladLazar requested a review from a team as a code owner June 26, 2024 14:08
@VladLazar VladLazar requested review from arpad-m and jcsp and removed request for arpad-m June 26, 2024 14:08
Copy link

2910 tests run: 2793 passed, 0 failed, 117 skipped (full report)


Code coverage* (full report)

  • functions: 32.8% (6888 of 21016 functions)
  • lines: 50.3% (53882 of 107180 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
17bfdd2 at 2024-06-26T15:25:03.753Z :recycle:

@VladLazar VladLazar changed the title strocon: don't overcommit when making node plan strocon: don't overcommit when making node fill plan Jun 27, 2024
@VladLazar VladLazar merged commit d557002 into main Jun 27, 2024
64 checks passed
@VladLazar VladLazar deleted the vlad/fix-fill-overcommit branch June 27, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants