-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement decompression for vectored reads #8302
Conversation
3048 tests run: 2933 passed, 0 failed, 115 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
c736123 at 2024-07-12T01:16:00.624Z :recycle: |
Flaky test looks like something significant:
|
Interesting, PS logs say (pageserver_3):
It uploaded that same file a little bit earlier as part of background compaction:
I also see it upload the
It's an interesting race. Maybe compression makes the situation worse due to taking more time, but in general it seems like an unrelated issue to me: there is earlier failures with the same error message (test_pg_regress[4] fails with a number of error messages). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would personally try a CI run of this PR rebased on #8288, but I leave it up to you.
before enabling it in staging or prod, I certainly will do that. I'd like to handle any upcoming issues in followups. |
Implement decompression of images for vectored reads.
This doesn't implement support for still treating blobs as uncompressed with the bits we reserved for compression, as we are removing that functionality in #8300 anyways.
Part of #5431