Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: pg17 fixes #8321

Merged
merged 6 commits into from
Jul 10, 2024
Merged

proxy: pg17 fixes #8321

merged 6 commits into from
Jul 10, 2024

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Jul 9, 2024

Problem

#7809 - we do not support sslnegotiation=direct
#7810 - we do not support negotiating down the protocol extensions.

Summary of changes

  1. Same as postgres, check the first startup packet byte for tls header 0x16, and check the ALPN.
  2. Tell clients using protocol >3.0 to downgrade

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jul 9, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_tenant_creation_fails: debug

Code coverage* (full report)

  • functions: 32.6% (6934 of 21287 functions)
  • lines: 50.0% (54546 of 109134 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3830be4 at 2024-07-09T17:42:24.567Z :recycle:

@conradludgate conradludgate marked this pull request as ready for review July 9, 2024 15:27
@conradludgate conradludgate requested a review from a team as a code owner July 9, 2024 15:27
Copy link
Contributor

@stradig stradig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conradludgate conradludgate merged commit fe13fcc into main Jul 10, 2024
66 checks passed
@conradludgate conradludgate deleted the pg-17-fixes branch July 10, 2024 08:10
skyzh pushed a commit that referenced this pull request Jul 15, 2024
## Problem

#7809 - we do not support sslnegotiation=direct
#7810 - we do not support negotiating down the protocol extensions.

## Summary of changes

1. Same as postgres, check the first startup packet byte for tls header
`0x16`, and check the ALPN.
2. Tell clients using protocol >3.0 to downgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants