Disable rust_2024_compatibility lint option

[hlinnaka]

Compiling with nightly rust compiler, I'm getting a lot of errors like this:

error: `if let` assigns a shorter lifetime since Edition 2024
   --> proxy/src/auth/backend/jwt.rs:226:16
    |
226 |             if let Some(permit) = self.try_acquire_permit() {
    |                ^^^^^^^^^^^^^^^^^^^-------------------------
    |                                   |
    |                                   this value has a significant drop implementation which may observe a major change in drop order and requires your discretion
    |
    = warning: this changes meaning in Rust 2024
    = note: for more information, see issue #124085 <https://github.com/rust-lang/rust/issues/124085>
help: the value is now dropped here in Edition 2024
   --> proxy/src/auth/backend/jwt.rs:241:13
    |
241 |             } else {
    |             ^
note: the lint level is defined here
   --> proxy/src/lib.rs:8:5
    |
8   |     rust_2024_compatibility
    |     ^^^^^^^^^^^^^^^^^^^^^^^
    = note: `#[deny(if_let_rescope)]` implied by `#[deny(rust_2024_compatibility)]`

and this:

error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
   --> proxy/src/auth/backend/jwt.rs:376:18
    |
369 |         let client = Client::builder()
    |             ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024
...
376 |             map: DashMap::default(),
    |                  ^^^^^^^^^^^^^^^^^^
    |
    = warning: this changes meaning in Rust 2024
    = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
    = note: `#[deny(tail_expr_drop_order)]` implied by `#[deny(rust_2024_compatibility)]`

They are caused by the rust_2024_compatibility lint option.

When we actually switch to the 2024 edition, it makes sense to go through all these and check that the drop order changes don't break anything, but in the meanwhile, there's no easy way to avoid these errors. Disable it, to allow compiling with nightly again.

[github-actions]

5363 tests run: 5141 passed, 0 failed, 222 skipped (full report)

---

Flaky tests (3)

Postgres 17

• test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64
• test_cancellations: debug-x86-64

Postgres 16

• test_lr_with_slow_safekeeper: release-arm64

Code coverage* (full report)

• functions: 31.7% (7852 of 24775 functions)
• lines: 49.4% (62105 of 125833 lines)

* collected from Rust tests only

---

_{The comment gets automatically updated with the latest test results
de9ee01 at 2024-11-07T23:26:58.355Z :recycle:}