Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count WAL flushes in walreceiver #139

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Count WAL flushes in walreceiver #139

merged 1 commit into from
Mar 8, 2022

Conversation

petuhovskiy
Copy link
Member

issue_xlog_fsync updates WalStats internally, but doesn't propagate it.

Stats can be accessed by querying SELECT wal_sync, wal_sync_time FROM pg_stat_wal on the replica. This is useful for comparing fsyncs between vanilla synchronous replication and safekeepers.

@petuhovskiy petuhovskiy requested a review from arssher February 24, 2022 14:50
arssher
arssher reviewed Feb 28, 2022
View reviewed changes
Copy link

@arssher arssher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure difference is measurable, but sounds better to do that when the process is idle (going to sleep on latch) instead of after each fsync.

@petuhovskiy petuhovskiy force-pushed the walreceiver-pgstat-wal branch 2 times, most recently from c0b4e8d to 730a6f7 Compare March 8, 2022 12:47
@petuhovskiy petuhovskiy force-pushed the walreceiver-pgstat-wal branch from 730a6f7 to 108bb39 Compare March 8, 2022 13:00
@petuhovskiy petuhovskiy merged commit ce7ff2d into main Mar 8, 2022
@petuhovskiy petuhovskiy deleted the walreceiver-pgstat-wal branch March 8, 2022 13:01
MMeent pushed a commit that referenced this pull request Jul 7, 2022
@petuhovskiy @MMeent
Count WAL flushes in walreceiver (#139)
2d2c207
MMeent pushed a commit that referenced this pull request Aug 18, 2022
@petuhovskiy @MMeent
Count WAL flushes in walreceiver (#139)
5f522f0
lubennikovaav pushed a commit that referenced this pull request Nov 21, 2022
@petuhovskiy @lubennikovaav
Count WAL flushes in walreceiver (#139)
4a9cee9
MMeent pushed a commit that referenced this pull request Feb 10, 2023
@petuhovskiy @MMeent
Count WAL flushes in walreceiver (#139)
c4dab7d
MMeent pushed a commit that referenced this pull request Feb 10, 2023
@petuhovskiy @MMeent
Count WAL flushes in walreceiver (#139)
5c033b4
MMeent pushed a commit that referenced this pull request May 11, 2023
@petuhovskiy @MMeent
Count WAL flushes in walreceiver (#139)
b9229ec
tristan957 pushed a commit that referenced this pull request Aug 10, 2023
@petuhovskiy @tristan957
Count WAL flushes in walreceiver (#139)
23091c5
tristan957 pushed a commit that referenced this pull request Nov 8, 2023
@petuhovskiy @tristan957
Count WAL flushes in walreceiver (#139)
8f44252
tristan957 pushed a commit that referenced this pull request Nov 8, 2023
@petuhovskiy @tristan957
Count WAL flushes in walreceiver (#139)
1e9f46c
tristan957 pushed a commit that referenced this pull request Feb 5, 2024
@petuhovskiy @tristan957
Count WAL flushes in walreceiver (#139)
77f8069
tristan957 pushed a commit that referenced this pull request Feb 5, 2024
@petuhovskiy @tristan957
Count WAL flushes in walreceiver (#139)
a6b4805
tristan957 pushed a commit that referenced this pull request Feb 6, 2024
@petuhovskiy @tristan957
Count WAL flushes in walreceiver (#139)
49a022a
tristan957 pushed a commit that referenced this pull request May 10, 2024
@petuhovskiy @tristan957
Count WAL flushes in walreceiver (#139)
24e2d63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arssher arssher arssher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petuhovskiy @arssher