Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed include for InRecovery #149

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fix missed include for InRecovery #149

merged 2 commits into from
Apr 25, 2022

Conversation

knizhnik
Copy link

No description provided.

@knizhnik knizhnik requested a review from hlinnaka April 25, 2022 15:42
@@ -26,6 +26,7 @@
#include "storage/buf_internals.h"
#include "storage/relfilenode.h"
#include "storage/smgr.h"
#include "access/xlog.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please keep the list in alphabetical order

@hlinnaka
Copy link
Contributor

for the commit message: InRecovery is only needed when building with --enable-cassert; that's why this was missed

@knizhnik knizhnik merged commit 3256ff3 into main Apr 25, 2022
@knizhnik knizhnik deleted the inmem_smgr_fix branch April 25, 2022 16:54
MMeent pushed a commit that referenced this pull request Jul 7, 2022
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
MMeent pushed a commit that referenced this pull request Aug 18, 2022
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
lubennikovaav pushed a commit that referenced this pull request Nov 21, 2022
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
MMeent pushed a commit that referenced this pull request Feb 10, 2023
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
MMeent pushed a commit that referenced this pull request Feb 10, 2023
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
MMeent pushed a commit that referenced this pull request May 11, 2023
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
tristan957 pushed a commit that referenced this pull request Aug 10, 2023
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
tristan957 pushed a commit that referenced this pull request Nov 8, 2023
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
tristan957 pushed a commit that referenced this pull request Nov 8, 2023
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
tristan957 pushed a commit that referenced this pull request Feb 5, 2024
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
tristan957 pushed a commit that referenced this pull request Feb 5, 2024
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
tristan957 pushed a commit that referenced this pull request Feb 6, 2024
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
tristan957 pushed a commit that referenced this pull request May 10, 2024
* Fix missed include for InRecovery

* Fix missed include for InRecovery (used only in debug version with --enable--cassert)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants