Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything compiles fine on our linux builds, but the compiler in our osx builds emits a
incompatible-function-pointer-types
warning:To me it looks like the
const
keyword intypedef const int64 (*dbsize_hook_type) (Oid dbOid);
is redundant. Anint64
returned as rvalue is const anyway, it's not a pointer. So maybe the compiler on linux ignores the const and compiles this, while the compiler on osx gets confused and emits a warning. I'm not sure if it's only confused in theory, or if it's confused enough to have undefined behavior, so I'd rather correct the definition and remove theconst
keyword.I checked that this patch fixes the warning on OSx.
Should we also fail CI on compiler warnings?