Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubennikovaav
approved these changes
Aug 12, 2022
src/backend/replication/walsender.c
Outdated
| @@ -3826,9 +3826,10 @@ LagTrackerRead(int head, XLogRecPtr lsn, TimestampTz now) | |||
| void | |||
| GetMinReplicaLsn(XLogRecPtr* write_lsn, XLogRecPtr* flush_lsn, XLogRecPtr* apply_lsn) | |||
There was a problem hiding this comment.
Do we need this function at all?
I don't see any calls
There was a problem hiding this comment.
I removed GetMinReplicaLsn function
MMeent
pushed a commit
that referenced
this pull request
Aug 18, 2022
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
lubennikovaav
pushed a commit
that referenced
this pull request
Nov 21, 2022
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
MMeent
pushed a commit
that referenced
this pull request
Feb 10, 2023
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
MMeent
pushed a commit
that referenced
this pull request
Feb 10, 2023
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
MMeent
pushed a commit
that referenced
this pull request
May 11, 2023
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
tristan957
pushed a commit
that referenced
this pull request
Aug 10, 2023
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
tristan957
pushed a commit
that referenced
this pull request
Feb 6, 2024
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
tristan957
pushed a commit
that referenced
this pull request
May 10, 2024
…192) * Eliminate UnkonwnXLogRecPtr and always use InvalidXLogRecPtr instead * Remove GetMinReplicaLsn function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaces #187