Init wal redo buffer for fpi #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
hlinnaka
approved these changes
Aug 15, 2022
MMeent
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
lubennikovaav
pushed a commit
that referenced
this pull request
Nov 21, 2022
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
MMeent
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
MMeent
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
MMeent
pushed a commit
that referenced
this pull request
May 11, 2023
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
tristan957
pushed a commit
that referenced
this pull request
Aug 10, 2023
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
tristan957
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
tristan957
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
tristan957
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
tristan957
pushed a commit
that referenced
this pull request
May 10, 2024
* Initialize wal_redo_buffer after applying record with FPI refer #1915 * Update comment * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> * Update src/backend/tcop/zenith_wal_redo.c Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi> Co-authored-by: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer neondatabase/neon#1915
We are using very small buffer cache and inmem file i wal redo postgres to minimize their restart time.
Right now we are protected target page using wal_redo_buffer variable.
This hack looks pretty ugly but I do not know better solution.
The problem is that now wal_redo_buffer is assigned only when base image is provided for page reconstruction.
But if wal records contains FPI, base image is not needed. In this case wal_redo_buffer is not initialized and so is not protected from eviction. This PR fixing this problem.
This bug cause index page corruption in ketteq project.
Replaces #179