applied fix for PG16 sanitizers #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares PostgreSQL for compatibility with Neon's storage. Significant changes compared to the PostgreSQL 15 patchset include: - Backported changes for users and roles are no longer required - Use RM_NEON_ID for changes in WAL, instead of modifying core WAL records
Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
* Neon logical replication support for PG16 * Log heap rewrite file after creation. --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech> Co-authored-by: Arseny Sher <sher-ars@yandex.ru>
Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
* Update WAL buffers when restoring WAL at compute needed for LR * Fix copying data in WAL buffers --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
PG16 adds new function to SMGR: zeroextend It's implementation in Neon actually wal-log zero pages of extended relation. This zero page is wal-logged using XLOG_FPI. As far as page is zero, the hole optimization (excluding from the image everything between pg_upper and pd_lower) doesn't work. This PR allows to set hole size to BLCKSZ in case of zero page (PageIsNull() returns true). --------- Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
* Prevent output callbacks from hearing about neon-file messages
|
Commenting here is case others missed my slack message, but this is upstream Postgres code. I would like to understand the issue at hand better. |
abhigets
force-pushed
the
add-build-sanitizers
branch
from
2088022 to
6f1ef95
Compare
tristan957
force-pushed
the
REL_16_STABLE_neon
branch
from
f7ea954 to
550cdd2
Compare
tristan957
force-pushed
the
REL_16_STABLE_neon
branch
from
8ef3c33 to
c271017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling sanitizers as a part of enabling build sanitizers
We need to add the following patch to PG16.
fix-REL_16_STABLE_neon-for-sanitizers.patch`
Before the fix [before fix 2_regress-tests (debug, v16).txt]
(https://github.com/neondatabase/postgres/files/13923603/before.fix.2_regress-tests.debug.v16.txt)
18 failed, 337 passed, 16 skipped, 2 xfailed, 9 errors, 1 rerun in 645.01s (0:10:45) =
After the fix [after the fix 2_regress-tests (debug, v16).txt]
(https://github.com/neondatabase/postgres/files/13923559/after.the.fix.2_regress-tests.debug.v16.txt)
1 failed, 355 passed, 16 skipped, 1 xfailed, 1 xpassed, 2 errors in 880.45s (0:14:40) =
One of the stack trace