removed LastWrittenLSN code and added hooks for the removed functions - v17 #590
+57
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
reviewed
Feb 28, 2025
| @@ -4952,8 +4923,8 @@ XLOGCtlShmemSize(void) | |||
| Size | |||
| XLOGShmemSize(void) | |||
| { | |||
| return XLOGCtlShmemSize() + | |||
| hash_estimate_size(lastWrittenLsnCacheSize, sizeof(LastWrittenLsnCacheEntry)); | |||
| // Removed LwLSN Size as it is no longer in XLog | |||
There was a problem hiding this comment.
If we remove the comment, is the function now the same as upstream postgres?
There was a problem hiding this comment.
Nope, it looks like upstream is doing a lot more: https://github.com/postgres/postgres/blob/424ededc580b03e1bcf8aff18a735e519c80061f/src/backend/access/transam/xlog.c#L4914
…sn cache moved to neon ext
thesuhas
force-pushed
the
move_lwlsn_neon_ext
branch
from
5182ec3 to
af7e7e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the LastWrittenLSN code from Postgres v17 as part of moving it into the neon extension to reduce code duplication.
Part of: neondatabase/neon#10973