[PG18] Add various hooks for SU functionality #849
+71
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality can allow users to get temporary SU permisions, within a certain scope. See $hadron$/pgxn/neon/su_statements.c for details.
HaoyuHuang
reviewed
Dec 29, 2025
| result = ((Form_pg_authid) GETSTRUCT(rtup))->rolsuper; | ||
| ReleaseSysCache(rtup); | ||
|
|
||
| if (!result && SUForUser_hook != NULL) |
There was a problem hiding this comment.
should we do this before the cache hit in line 63?
Author
There was a problem hiding this comment.
No, our handling of this is cache-aware: Every time we add/drop a level of the stack we reset the cache.
This is exactly what we do for privileged_role_name. It reduces the amount of changes in the fork. Signed-off-by: Tristan Partin <tristan.partin@databricks.com>
This functionality can allow users to get temporary SU permisions, within a certain scope. See $hadron$/pgxn/neon/su_statements.c for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality can allow users to get temporary SU permisions, within a certain scope.