Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refractored Skyblock Objects to not use inner classes. #127

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Refractored Skyblock Objects to not use inner classes. #127

wants to merge 9 commits into from

Conversation

Nopock
Copy link
Contributor

@Nopock Nopock commented Jun 9, 2023

Feel free to make changes.

@Nopock Nopock requested review from Netwyn and unpluggedsam June 9, 2023 05:53
Netwyn
Netwyn reviewed Jun 10, 2023
View reviewed changes
Copy link
Contributor

@Netwyn Netwyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProfileMember class seems a bit bloated; perhaps you could extract some of that data into a Catacombs class or something of the like?

Also combine CurrentCommunityUpgrade with ProfileCommunityUpgrades

@Netwyn
Copy link
Contributor

Netwyn commented Jun 10, 2023 •
edited
Loading

After that it should be fine to merge.

@Nopock
Copy link
Contributor Author

Nopock commented Jun 10, 2023

ProfileMember class seems a bit bloated; perhaps you could extract some of that data into a Catacombs class or something of the like?

Also combine CurrentCommunityUpgrade with ProfileCommunityUpgrades

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Netwyn Netwyn Netwyn left review comments

@unpluggedsam unpluggedsam Awaiting requested review from unpluggedsam

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nopock @Netwyn