This repository was archived by the owner on Feb 28, 2024. It is now read-only.
Document the other ways NML touches neos #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EIA485
previously approved these changes
Aug 2, 2022
XDelta
suggested changes
Aug 2, 2022
doc/how_nml_works.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Going Into Detail: How NeosModLoader Interfaces with Neos | |||
|
|
|||
| NeosModLoader only interfaces with Neos in two places: the hook and the compatibility hash. | |||
| NeosModLoader with Neos in two main places: the hook and the compatibility hash. | |||
There was a problem hiding this comment.
Seems to be missing 'interfaces with'
doc/how_nml_works.md
Outdated
| @@ -32,3 +32,8 @@ In order to make a client using NeosModLoader compatible with vanilla Neos the c | |||
| [components]: https://wiki.neos.com/Component | |||
| [logix]: https://wiki.neos.com/LogiX | |||
| [data model]: https://wiki.neos.com/Core_Concepts#Data_Model | |||
|
|
|||
| ## Other Minor Ways NeosModLoader Touches Neos | |||
There was a problem hiding this comment.
Reads weird, may want to reuse 'Interfaces with' or list it as addition hooks.
Alternatively could refer to the main ones as 'Primary' and these as 'Secondary' hooks.
Primary as required to function
Secondary as QoL/additional features
l-2-j
approved these changes
Aug 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sls asked for this https://discord.com/channels/901126079857692714/901129181453230130/1003774038675574845