Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doctrine dependencies #2122

Closed
albe opened this issue Sep 13, 2020 · 10 comments · Fixed by #1880
Closed

Update doctrine dependencies #2122

albe opened this issue Sep 13, 2020 · 10 comments · Fixed by #1880
Labels
dependencies Feature P: Flow T: Database

Comments

@albe
Copy link
Member

albe commented Sep 13, 2020

doctrine/common and doctrine/migrations are due for an update for some time. Doctrine/common is even supposed to be phased out (https://www.doctrine-project.org/2018/07/12/common-2-9-and-dbal-2-8-and-orm-2-6-2.html). Doctrine/orm is still okay with 2.7, but 2.8.x is in the making.
see #1880, #2026 & #2021
@albe albe mentioned this issue Sep 13, 2020
Merged
@kdambekalns
Copy link
Member

I'd love to tackle this (at least partly), after all #1880 has been there for… uhm… ages. 😬

@kdambekalns
Copy link
Member

On doctrine/common:

$ composer why doctrine/common
doctrine/orm                      2.7.4        requires  doctrine/common (^2.11 || ^3.0)
gedmo/doctrine-extensions         v2.4.42      requires  doctrine/common (~2.4)
neos/flow-development-collection  9999999-dev  requires  doctrine/common (^2.4)
neos/neos-development-collection  9999999-dev  requires  doctrine/common (^2.7)

If we update gedmo/doctrine-extensions to 3.0.0, we could use doctrine/common as ^3.0 - the changes seem reasonable: https://github.com/Atlantic18/DoctrineExtensions/releases/tag/v3.0.0

@albe
Copy link
Member Author

albe commented Nov 10, 2020 •
edited
Loading

We have a dependency on gedmo/doctrine-extensions? 🤯

Edit: I can't find anything like that, also not in the travis build installs (e.g. https://travis-ci.com/github/neos/flow-development-collection/jobs/431583293#L466 ff) 🤔 are you sure you don't just have that installed locally?

@kdambekalns
Copy link
Member

Neos, not Flow: https://github.com/neos/neos-development-collection/search?q=gedmo%2Fdoctrine-extensions

@kdambekalns
Copy link
Member

Timestamps in NodeData: https://github.com/neos/neos-development-collection/search?q=Gedmo

@albe
Copy link
Member Author

albe commented Nov 10, 2020

Ah, okay!

@kdambekalns
Copy link
Member

kdambekalns added a commit to kdambekalns/party that referenced this issue Nov 13, 2020
@kdambekalns
TASK: Apply migration Neos.Flow-20201109224100
f512799 
Adjust DB migrations to Doctrine Migrations 3.0

See neos/flow-development-collection#1880
See neos/flow-development-collection#2122
@kdambekalns
Copy link
Member

kdambekalns commented Nov 13, 2020 •
edited
Loading

Not so fast, GH automation!

@kdambekalns kdambekalns reopened this Nov 13, 2020
@albe albe mentioned this issue Nov 13, 2020
Merged
@albe
Copy link
Member Author

albe commented Nov 16, 2020

Only #2247 left and this can be closed 🎉

@kdambekalns kdambekalns mentioned this issue Nov 17, 2020
Merged
@markusguenther
Copy link
Member

As all PRs are merged I will close this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Feature P: Flow T: Database
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

!!! TASK: Update Doctrine Migrations to 3.0 kdambekalns/flow-development-collection
4 participants
@kdambekalns @bwaidelich @markusguenther @albe