-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Use GH actions for builds #2273
Conversation
Regarding testing against PHP 8 (or any other "allow-failure" dependency) - see actions/runner#2347 |
Removes necessity to run ComposerManifestUpdater, adds matrix config for static analysis and lowest dependency versions
# Conflicts: # .travis.yml
…-gh-action-builds
Guess that's because there's a discrepancy in the relative placement of the distribution and collection in travis vs this? Or is it because of (not) symlinking the collection and paths being resolved differently? |
Solved by using non-symlinking path repo in the composer config, like in #2287 Now two console output tests fail oddly:
I have seen this failure on my windows runs, but always assumed that was due to how windows PHP handled console output. So I'm unsure what the cause is in this case, as the build is running on ubuntu |
TODO: Get remaining skipped tests running (I guess those are primarily the cache tests for specific backends) |
Possible alternative for setting up the database service so it is configurable per run (e.g. could be skipped for static analysis run): https://github.com/cakephp/cakephp/blob/master/.github/workflows/ci.yml#L41-L55 |
Still 38 skipped Unit tests and 30 skipped Functional tests... 🤔 anyone has an idea? @kdambekalns ? |
Also this ignores the Settings.example file
Only a few skipped tests remaining now, which are semi-concious choices and not dependent on the setup. We need to revisit those at some point. LGTM, but I will create another PR for 5.3 so we have builds across all branches after an upmerge. |
Still WIP, needs to be backported to lowest maintained branch once finished, but I want to get psalm running too and that's not in <6.0