WIP: Assert that write side does not operate on fake workspace names

neos · Jun 29, 2024 · 10011fb · 10011fb
1 parent b8d48c4
commit 10011fb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/Neos.ContentRepository.Core/Classes/CommandHandlingDependencies.php b/Neos.ContentRepository.Core/Classes/CommandHandlingDependencies.php
@@ -65,6 +65,10 @@ public function getContentGraph(WorkspaceName $workspaceName): ContentGraphInter
             return $this->overridenContentGraphInstances[$workspaceName->value];
         }
 
+        if ($workspaceName->isReferencingUnusedContentStream()) {
+            throw new \RuntimeException(sprintf('Expected actual workspace name. Got a workspace name referencing an unused content stream: "%s" instead.', $workspaceName->getReferencingUnusedContentStreamId()->value), 1719648458);
+        }
+
         return $this->contentRepository->getContentGraph($workspaceName);
     }
 

diff --git a/Neos.ContentRepository.Core/Classes/Feature/WorkspaceCommandHandler.php b/Neos.ContentRepository.Core/Classes/Feature/WorkspaceCommandHandler.php
@@ -900,6 +900,10 @@ private function handleChangeWorkspaceOwner(
 
     private function requireWorkspaceToNotExist(WorkspaceName $workspaceName, CommandHandlingDependencies $commandHandlingDependencies): void
     {
+        if ($workspaceName->isReferencingUnusedContentStream()) {
+            throw new \RuntimeException(sprintf('Expected actual workspace name. Got a workspace name referencing an unused content stream: "%s" instead.', $workspaceName->getReferencingUnusedContentStreamId()->value), 1719648458);
+        }
+
         try {
             $commandHandlingDependencies->getContentGraph($workspaceName);
         } catch (WorkspaceDoesNotExist) {
@@ -918,6 +922,10 @@ private function requireWorkspaceToNotExist(WorkspaceName $workspaceName, Comman
      */
     private function requireWorkspace(WorkspaceName $workspaceName, WorkspaceFinder $workspaceFinder): Workspace
     {
+        if ($workspaceName->isReferencingUnusedContentStream()) {
+            throw new \RuntimeException(sprintf('Expected actual workspace name. Got a workspace name referencing an unused content stream: "%s" instead.', $workspaceName->getReferencingUnusedContentStreamId()->value), 1719648458);
+        }
+
         $workspace = $workspaceFinder->findOneByName($workspaceName);
         if (is_null($workspace)) {
             throw WorkspaceDoesNotExist::butWasSupposedTo($workspaceName);