9.0 Avoid getActiveRequestHandler in node property mapper for uncached fusion rendering

[mhsdesign]

For fusions uncached context variables (in the uncached mode) to work one needs a property mapper to serialize the variable to a string see code.

This is problematic for nodes in neos 9 as its string representation (the NodeAdress) doesnt serialize the content repository id: #4441

Previously in Neos 8.3 this was not a problem as a node could be easily resolved from a context path as there was no ambiguity of multiple content repositories.

To solve this obstacle (temporary?) we currently have this NewNodeConverter which has quite a side effect to get a content repository out of the blue:

neos-development-collection/Neos.Neos/Classes/Fusion/NewNodeConverter.php

Lines 70 to 76 in 9dd4ed5

	$activeRequestHandler = $this->bootstrap->getActiveRequestHandler();
	$contentRepositoryId = ContentRepositoryId::fromString('default');
	if ($activeRequestHandler instanceof RequestHandler) {
	$httpRequest = $activeRequestHandler->getHttpRequest();
	$siteDetectionResult = SiteDetectionResult::fromRequest($httpRequest);
	$contentRepositoryId = $siteDetectionResult->contentRepositoryId;
	}

Using the activeRequest of the bootstrap like this will make it impossible to render fusion from the cli.

This fix was introduced with 763f293

I would not like to ship this code for Neos 9 final release as this property mapping would also allow implicit code like this to work:

public function nodeAction(Node $node): {}

This might be dangerous as its abstracts away the request, to content repository id mapping and besides is not testable as it doesnt use the action request of the controller but the one from the bootstrap.

-> extracted discussion to here: #4873

[mhsdesign]

@kitsunet wrote

Why do we not have a fully qualified node serialization format, that would help it I guess

Thats what i implemented here: #4734

but i guess maybe this should rather be part of the cr itself see NodeIdentity in #4564

[kitsunet]

I am not so good with discussion here where here is not "there" 😂 too many place overflow...
Anyways yes I would rpefer a more unified solution, that also potentially gets rid of the \Neos\Neos\FrontendRouting\NodeAddress::serializeForUri in favor of a fully qualified format.

[mficzel]

We will have to add the cr id to a node address anyways. So why not do it sooner than later.