Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Consistently use correct cr identifier across delegated cr:* commands #4400

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

grebaldi
Copy link
Contributor

The problem

In Neos.ContentRepository, ./flow cr:prune delegates internally to cr:replayall, but misses to pass its given --content-repository parameter to the subsequent command.

Likewise, in Neos.Neos, ./flow cr:import delegates internally to neos.contentrepositoryregistry:cr:replayall, and also misses to pass its given --content-repository parameter to the subsequent command.

The solution

I fixed cr:prune by passing the missing parameter to the $this->replayAllCommand(...) call.

cr:import was actually attempting to pass the content repository identifier, but did so with a misspelled parameter name. I fixed it by correcting the name.

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bwaidelich bwaidelich merged commit 093cd64 into neos:9.0 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants