-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! FEATURE: Reimplement EditPreviewModes for Neos 9 #4505
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6d00b3e
FEATURE: Implement EditPreviewModes for Neos 9 with the new CR
mficzel 70d2179
TASK: Introduce constant `RenderingMode::FRONTEND` for system integra…
mhsdesign e2c6f5e
TASK: RenderingModeService instances runtime cache
mhsdesign 0463da9
TASK: Remove half-baked solution of session independent preview's
mhsdesign 5639b6b
TASK: Optimize runtime cache for RenderingModes for readability
mficzel 3202c4e
Merge pull request #4521 from neos/90/editPreviewModeSupport_v3_review
mficzel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Neos.Neos package. | ||
* | ||
* (c) Contributors of the Neos Project - www.neos.io | ||
* | ||
* This package is Open Source Software. For the full copyright and license | ||
* information, please view the LICENSE file which was distributed with this | ||
* source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Neos\Neos\Domain\Model; | ||
|
||
use Neos\Utility\ObjectAccess; | ||
mficzel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/** | ||
* Describes the mode in which the Neos interface is rendering currently, | ||
* mainly distinguishing between edit and preview modes currently. | ||
*/ | ||
class RenderingMode | ||
{ | ||
/** | ||
* @param array<string,mixed> $options | ||
*/ | ||
public function __construct( | ||
public readonly string $name, | ||
public readonly bool $isEdit, | ||
public readonly bool $isPreview, | ||
public readonly string $title, | ||
public readonly string $fusionPath, | ||
public readonly array $options | ||
) { | ||
} | ||
|
||
/** | ||
* Creates an UserInterfaceMode object by configuration | ||
* | ||
* @param string $modeName | ||
* @param array<string,mixed> $configuration | ||
*/ | ||
public static function createFromConfiguration(string $modeName, array $configuration): RenderingMode | ||
{ | ||
$mode = new RenderingMode( | ||
$modeName, | ||
$configuration['isEditingMode'] ?? false, | ||
$configuration['isPreviewMode'] ?? false, | ||
$configuration['title'] ?? $modeName, | ||
$configuration['fusionRenderingPath'] ?? '', | ||
$configuration['options'] ?? [], | ||
); | ||
return $mode; | ||
} | ||
|
||
/** | ||
* Creates the live User interface mode | ||
*/ | ||
public static function createFrontend(): RenderingMode | ||
{ | ||
return new RenderingMode( | ||
'frontend', | ||
false, | ||
false, | ||
'Frontend', | ||
'', | ||
[] | ||
); | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, the ui will currently not use this parameter yet (it could via neos/neos-ui#3411)
But importantly this change allows us to open a page in a new tab independent of the session's value.
Although this would only work for this one page, successive links will currently not have that query param added - the linking service still needs to lear this, but this is out of scope of this pr.