Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE 4327 - Expose a subgraph's identity #4678

Merged
merged 1 commit into from
Nov 1, 2023
Merged

FEATURE 4327 - Expose a subgraph's identity #4678

merged 1 commit into from
Nov 1, 2023

Conversation

nezaniel
Copy link
Member

@nezaniel nezaniel commented Nov 1, 2023

Resolves #4327

This exposes the subgraph identity in the ContentSubgraphInterface

Checklist

  • Code follows the PSR-12 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the 9.0 branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Nov 1, 2023
skurfuerst
skurfuerst approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from my side :)

@nezaniel nezaniel merged commit e9f2eaa into 9.0 Nov 1, 2023
5 checks passed
@nezaniel nezaniel deleted the 4327-subgraphIdentity branch November 1, 2023 23:31
@mhsdesign mhsdesign mentioned this pull request Mar 19, 2024
Closed
35 tasks
@mhsdesign mhsdesign mentioned this pull request May 22, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@dlubitz dlubitz dlubitz approved these changes

@skurfuerst skurfuerst skurfuerst approved these changes

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@kitsunet kitsunet Awaiting requested review from kitsunet

@mficzel mficzel Awaiting requested review from mficzel

@ahaeslich ahaeslich Awaiting requested review from ahaeslich

Assignees
No one assigned
Labels
9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion: Should ContentSubgraphInterface know its ContentSubgraphIdentity?
4 participants
@nezaniel @skurfuerst @dlubitz @mhsdesign