Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: 4824 FusionExceptionView doesnt set editPreviewMode correctly #4827

Merged
merged 1 commit into from
Jan 31, 2024
Merged

BUGFIX: 4824 FusionExceptionView doesnt set editPreviewMode correctly #4827

merged 1 commit into from
Jan 31, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jan 12, 2024 •
edited
Loading

Resolves #4824
Regression from #4505

The variable is expected (by convention) to be renderingMode and hold a RenderingMode instance.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign merged commit 60d0419 into neos:9.0 Jan 31, 2024
9 checks passed
@mhsdesign mhsdesign deleted the bugfix/4824-FusionExceptionView-doesnt-set-editPreviewMode branch January 31, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

Assignees
No one assigned
Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering of the 404 Not Found page breaks because renderingMode is not available
2 participants
@mhsdesign @kitsunet