-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Pass ContentStreamId to NodeFactory #4941
TASK: Pass ContentStreamId to NodeFactory #4941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by reading 👀
Why is this necessary? |
@mhsdesign requested that as preparation for the node identity. |
Mmmm, @mhsdesign gimme some more background. Shouldn't we resolve this some other place before hitting this? |
@kitsunet Thats what we discussed in the weekly from the 01-03-2024.
|
And its good to see that all tests pass, because that means we never fetch foreign nodes in a subgraph. |
Bastians subtree tag pr goes first. And yes we discussed that we can remove the csStreamId from the selects, which might even be noticeable for recursive queries. |
08794f0
to
0deca11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 by reading
No description provided.