BUGFIX: Strip image to prevent wrong orientation information in exif data #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlubitz
force-pushed
the
bugfix/strip-image
branch
from
a3117e1 to
6b5e4fb
Compare
ahaeslich
reviewed
Mar 15, 2024
jonnitto
approved these changes
Mar 18, 2024
|
We strip already the image in ResizeImageAdjustment: But the CropImageAdjustment is applied before the ResizeImageAdjustment, so the strip is to late for the cropping. This change just do the stripping before all adjustments get applied. I would suggest to remove the "strip()" in the ResizeImageAdjustment in Neos 9.0, in case someone is relying on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After autorotating the thumbnail image we need to remove the according exif data for the thumbnail, to prevent the thumbnail is shown rotated again.
See also: php-imagine/Imagine#467
Fixes: #3148