WIP: BUGFIX: Enable WorkspaceRuntimeCache and ContentSubgraphWithRuntimeCaches after disabling
#4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
commented
Mar 19, 2024
| @@ -138,6 +138,7 @@ public function reset(): void | |||
| $this->getDatabaseConnection()->exec('TRUNCATE ' . $this->tableName); | |||
| $this->checkpointStorage->acquireLock(); | |||
| $this->checkpointStorage->updateAndReleaseLock(SequenceNumber::none()); | |||
| $this->workspaceRuntimeCache->enableCache(); | |||
There was a problem hiding this comment.
on the other hand this will not really be called in production.
The same is with the ContentSubgraphWithRuntimeCaches. it seems we never reenable the cache if marked once as stale (during event handling)
mhsdesign
changed the title
WorkspaceRuntimeCache after disablingWorkspaceRuntimeCache and ContentSubgraphWithRuntimeCaches after disabling
mhsdesign
changed the title
WorkspaceRuntimeCache and ContentSubgraphWithRuntimeCaches after disablingWorkspaceRuntimeCache and ContentSubgraphWithRuntimeCaches after disabling
|
Discussion should happen over at #5039 first and then a concrete implementation will follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kitsunet and me stumbled upon that we only ever disable the workspace runtime cache but never reenable it.
For the subgraph cache, we enable it also again on reset:
neos-development-collection/Neos.ContentGraph.DoctrineDbalAdapter/src/DoctrineDbalContentGraphProjection.php
Line 169 in 882b572
But it seems reenabling on reset is too simple. Reset will not actually be executed in a normal live cycle.
Maybe we can just flush the cache instead of disable and it is still hot?
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions