Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves partially #5034
This adjusts the test suite to operate directly on workspace names instead of content stream IDs
Upgrade instructions
Review instructions
Most changes are purely search/replace, with a few exceptions:
https://github.com/neos/neos-development-collection/compare/5034-workspaceBasedTests?expand=1#diff-2e50430c540d541e90b7b2233957a44a9d2fb4e8240d3de077bbc93192d3cc65R306
Here we check the timestamps in the new content stream instead of the closed one as before, thus the change in payload, as discussed with @bwaidelich in Slack
https://github.com/neos/neos-development-collection/compare/5034-workspaceBasedTests?expand=1#diff-a3b3697e967ca37986b11850c79037b9594ba0742f7cf2da5a140f31f85701a3L81
Has been refactored to use the given content stream id and the matching workspace instead of the unrelated current workspace name.
Also, we cannot remove content stream checks as we have test cases for content stream forking without workspaces being involved. Also, structure adjustments don't use workspaces, so we have to again check content streams
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions