Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: WIP Prepare for synchronous content repository #5049

Merged

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 12, 2024

In preparation for #4988 this will adjust the cr to be synchronous already via a hack and adds a slim b/c block layer which will be removed with the next beta to ease migration.

Upgrade instructions

The CommandResult::block calls must be removed as the backwards compatibility layer will be removed with next beta.

- $contentRepository->handle($command)->block();
+ $contentRepository->handle($command);

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

- `ContentRepository::handle()` will block by default
@mhsdesign mhsdesign force-pushed the task/deprecateManualCommandHandlingBlocking branch from 2f0039c to 18f200f Compare May 13, 2024 06:19
@mhsdesign mhsdesign changed the title TASK: Block ContentRepository::handle() by default TASK: WIP Prepare synchronous cr May 13, 2024
@mhsdesign mhsdesign changed the title TASK: WIP Prepare synchronous cr TASK: WIP Prepare synchronous content repository May 13, 2024
@mhsdesign mhsdesign changed the title TASK: WIP Prepare synchronous content repository TASK: WIP Prepare for synchronous content repository May 13, 2024
@mhsdesign mhsdesign requested a review from bwaidelich May 13, 2024 07:17
@mhsdesign mhsdesign merged commit ee035e7 into neos:9.0 May 13, 2024
13 checks passed
@mhsdesign mhsdesign deleted the task/deprecateManualCommandHandlingBlocking branch May 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants