Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Cleanup change projection after publish and discard #5384

Merged
merged 6 commits into from
Dec 4, 2024
Merged

FEATURE: Cleanup change projection after publish and discard #5384

merged 6 commits into from
Dec 4, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Nov 29, 2024

Fixes #4998

@github-actions github-actions bot added the 9.0 label Nov 29, 2024
@kitsunet
Copy link
Member

Very nice! This is draft because it misses handling of publish still, right?

@dlubitz
Copy link
Contributor Author

dlubitz commented Nov 30, 2024

No, because of missing tests. :D Wanted to write some more tests for the change projection.

@dlubitz dlubitz force-pushed the feature/90/cleanup-change-projection-after-publish branch from 7b43d3f to 519c03f Compare December 3, 2024 15:43
@dlubitz dlubitz marked this pull request as ready for review December 3, 2024 15:44
@dlubitz dlubitz changed the title WIP FEATURE: Cleanup change projection after publish and discard EATURE: Cleanup change projection after publish and discard Dec 3, 2024
@dlubitz dlubitz changed the title EATURE: Cleanup change projection after publish and discard FEATURE: Cleanup change projection after publish and discard Dec 3, 2024
@dlubitz dlubitz requested review from bwaidelich and mhsdesign and removed request for bwaidelich December 3, 2024 15:56
@dlubitz dlubitz mentioned this pull request Dec 3, 2024
Merged
kitsunet
kitsunet approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many tests! Thank you <3

@kitsunet kitsunet enabled auto-merge December 3, 2024 18:53
mhsdesign
mhsdesign reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow thank you sooo much for all the work ❤️ , they also work locally as expected!

And also the new ContentStreamWasRemoved behaviour works as quite some tests fail without ^^

id say move the tests into PendingChange dir, its also configured under that name

...ior/Features/Change/01-NodeCreation/01-CreateNodeAggregateWithNode_WithoutDimensions.feature Outdated Show resolved Hide resolved
Neos.Neos/Tests/Behavior/Features/Bootstrap/ChangeProjectionTrait.php Show resolved Hide resolved
...havior/Features/Change/01-NodeCreation/02-CreateNodeAggregateWithNode_WithDimensions.feature Outdated Show resolved Hide resolved
....Neos/Tests/Behavior/Features/Change/07-NodeMove/02-MoveNodeAggregate_WithDimensions.feature Outdated Show resolved Hide resolved
...hange/W01-WorkspacePublication/04-PublishIndividualNodesFromWorkspace_WithDimensions.feature Outdated Show resolved Hide resolved
@dlubitz dlubitz requested a review from mhsdesign December 3, 2024 21:45
mhsdesign
mhsdesign approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect ;)

@kitsunet kitsunet merged commit a897790 into neos:9.0 Dec 4, 2024
9 checks passed
bwaidelich
bwaidelich reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Post-merge-plus-one 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich left review comments

@mhsdesign mhsdesign mhsdesign approved these changes

@kitsunet kitsunet kitsunet approved these changes

Assignees
No one assigned
Labels
9.0 Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TASK: ChangeProjection should clean up orphaned change records
4 participants
@dlubitz @kitsunet @bwaidelich @mhsdesign