Skip to content

Commit

Permalink
TASK: Avoid use of internal sequenceNumber for building commands th…
Browse files Browse the repository at this point in the history
…at failed

instead we can just generate a uuid as the `sequenceNumber` was also unique for each command that failed

see neos/neos-development-collection#5301 (comment)
  • Loading branch information
mhsdesign committed Oct 28, 2024
1 parent 7468ffb commit 15c13ab
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Classes/Infrastructure/ContentRepository/ConflictsFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ private function createConflictFromCommandThatFailedDuringRebase(

return new Conflict(
key: $affectedNode
? $affectedNode->aggregateId->value
: 'command-' . $commandThatFailedDuringRebase->sequenceNumber->value,
? $affectedNode->aggregateId->value
: Algorithms::generateUUID(),
affectedSite: $affectedSite
? $this->createIconLabelForNode($affectedSite)
: null,
Expand Down

0 comments on commit 15c13ab

Please sign in to comment.