Skip to content

BUGFIX: fix neos-ui-extensibility by transpiling it to JS #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2019

Conversation

dimaip
Copy link
Contributor

@dimaip dimaip commented Feb 2, 2019

We should transpile all packages that we publish to npm.
For now I started with positional-array-sorter and neos-ui-extensibility.

Don't mind the beta version, will be overwritten by next release.

Problems to solve in the future:

  1. it's not possible to build both subpackages and the UI itself in watch mode. For now it's not a big issue as we don't have many subpackages with separate build steps, but that would become an issue if we'd want to publish it. HELP WANTED TO IMPROVE IT.
  2. Subpackages have to be built in the order they depend on each other. So far it just concides with the alphabetical order, therefore it works.

Perhaps smth like this could solve these problems in the future: microsoft/TypeScript#17611

@dimaip dimaip merged commit 33d9b1c into neos:2.x Feb 4, 2019
@dimaip dimaip deleted the fix-ext branch February 4, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant