Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix ckeditor inline mode autoparagraph: false #3532

Merged
merged 6 commits into from
Jun 29, 2023

Commits on Jun 21, 2023

  1. Configuration menu
    Copy the full SHA
    034fe0e View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. BUGFIX: Fix inline ckeditor mode

    Since there is still no native support for a inline ckeditor mode. ckeditor/ckeditor5#762 we will continue our hacky road ;)
    
    This fixes several issues:
    - Inserting text with newlines will now correctly insert soft breaks (br)
    - We use our own pseodo `<neos-inline-wrapper>` tag to avoid the issue of having to parse html with regex and doing it wrong #2918
    
    i also added a test for some inline editing behavior. (Like that there are no outer span or p tags)
    But writing a tests for #2918 is currently impossible, as our tests currently dont use `https` which means we cant access the `navigator.clipboard` and test that ckeditor works correctly when content is pasted.
    mhsdesign committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7c9fc84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3da3845 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Configuration menu
    Copy the full SHA
    c2d3da1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    edbf0d6 View commit details
    Browse the repository at this point in the history
  3. BUGFIX: Fix cleanupContentBeforeCommit and add test

    Fix bug in the case you had multiple paragraphs and a headline and switched to autoparagrahp: false
    mhsdesign committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    bdd46a5 View commit details
    Browse the repository at this point in the history