BUGFIX: 3574 initialize foreign referenced nodes

[mhsdesign]

resolves: #3574

actual fix instead of hotfix: #3575 and neos/neos-development-collection#4399

similar to @grebaldi solution at: #3364

What I did

How I did it

How to verify it

revert: neos/neos-development-collection#4399 and try to follow #3574

[Sebobo]

Should we go with both PRs just to be one the safe side?

[mhsdesign]

No I rather not - I like to be more explicit and if we just ignore any unexpected input wrong behaviour will later be worse to debug then if there was an exception.

we can still write a safeguard and log an error to the console if you want…

[Sebobo]

Yes then I will adjust my PR to do that. The code there just relies too much on data being there.

[dlubitz]

I like! ❤️ I can't evaluate the technical solution, but it looks reasonable.

[grebaldi]

LGTM code-wise.

However, I was unable to reproduce the issue as per description in #3574.

[mhsdesign]

However, I was unable to reproduce the issue as per description in #3574.

Maybe because we have the hotfix #3575 already merged? (So the console output should still complain, but less so)

Also for future reviewers: Make sure to revert neos/neos-development-collection#4399 once its merged ;)

[grebaldi]

@mhsdesign

Maybe because we have the hotfix #3575 already merged? (So the console output should still complain, but less so)

Oh yes, didn't see that :)