Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: 3594 reduce deprecation logs #3601

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Aug 23, 2023

Closes #3594

What I did

Reduce maximal logs to 20. (This will most likely then only warn about the first loaded plugin instead all affected plugins, but its hard to determine the plugin who called)

Also console.warn was replaced with error to have also stack straces in safari and firefox:

(you can expand the arrow)

image

How I did it

How to verify it

@github-actions github-actions bot added Bug Label to mark the change as bugfix 8.3 labels Aug 23, 2023
@mhsdesign mhsdesign linked an issue Aug 23, 2023 that may be closed by this pull request
@Sebobo
Copy link
Member

Sebobo commented Aug 24, 2023

I think even 5 or 10 entries would be enough. Isn't there a way to look at the call stack and see which file caused it?
This way we could show it once for each JS file.

@mhsdesign
Copy link
Member Author

mhsdesign commented Aug 24, 2023

Hmm yes i thought about this too, but the string output of (new Error).stack is not standardized - the whole property isnt. And it looks on every Browser different and must be parsed differently - idk if its worth it?

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack?retiredLocale=de

Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like it, but have to better idea 🤷🏻‍♂️

@mhsdesign mhsdesign merged commit 12f7bd5 into 8.3 Aug 25, 2023
4 checks passed
@mhsdesign mhsdesign deleted the bugfix/3594-reduce-deprecation-logs branch August 25, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG plow deprecated log spamming
3 participants