TASK: 9.0 migrate node.context.currentRenderingMode.edit

[mhsdesign]

node.context is not available anymore.

https://github.com/neos/neos-development-collection/blob/f4ed8369957209ba689cb2e1d9319e39716d6ac3/Neos.Neos/Resources/Private/Fusion/Prototypes/ContentCollection.fusion#L30

[mhsdesign]

see
#23

${Neos.Backend.isEditMode(request)}

[dlubitz]

We need to specify that more in detail. I already found recgtor migrations, but AFAIS they are already outdated right?

Fusion

rector/src/ContentRepository90/Rules/FusionContextLiveRector.php

Line 15 in 618a7fd

return CodeSampleLoader::fromFile('Fusion: Rewrite node.context.live to Neos.Node.isLive(...)', __CLASS__);

rector/src/ContentRepository90/Rules/FusionContextInBackendRector.php

Line 15 in 618a7fd

return CodeSampleLoader::fromFile('Fusion: Rewrite node.context.inBackend to Neos.Node.inBackend(...)', __CLASS__);

rector/src/ContentRepository90/Rules/FusionContextCurrentSiteRector.php

Line 22 in 618a7fd

'/(node|documentNode|site|[a-zA-Z]+)\.context\.currentSite/',

What about PHP migrations here?

And we miss migrations for currentRenderingMode at all.

rector/config/set/contentrepository-90.php

Lines 262 to 283 in 618a7fd

	/**
	* ContentContext
	*/
	// ContentContext::getCurrentSite
	// TODO: PHP
	$rectorConfig->rule(FusionContextCurrentSiteRector::class);
	// TODO: Fusion
	// ContentContext::getCurrentDomain
	// TODO: PHP
	// TODO: Fusion
	// ContentContext::getCurrentSiteNode
	// TODO: PHP
	// TODO: Fusion
	// ContentContext::isLive -> Neos.Node.isLive(...)
	// TODO: PHP
	$rectorConfig->rule(FusionContextLiveRector::class);
	// ContentContext::isInBackend -> Neos.Node.inBackend(...)
	// TODO: PHP
	$rectorConfig->rule(FusionContextInBackendRector::class);
	// ContentContext::getCurrentRenderingMode
	// TODO: PHP
	// TODO: Fusion

[ahaeslich]

@mficzel updated some old migrations already before deleting the eel helper we temporarily used. So yes information in this package might be outdated.

[mficzel]

Migration seems right but I probably did not adjust the comment

[dlubitz]

That's right. I already cleaned that up: #27

But they are just for fusion and for example node.context.currentRenderingMode is still not covered, right?

Also the other ContentContext methods might need some rector rewrites?

[mficzel]

Yes. We should migrate currentRendering mode aswell.