Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentContext::getCurrentRenderingMode to RenderingModeService::findByCurrentUser #31

Closed
Tracked by #25
dlubitz opened this issue Oct 23, 2023 · 2 comments · Fixed by #36
Closed
Tracked by #25

ContentContext::getCurrentRenderingMode to RenderingModeService::findByCurrentUser #31

dlubitz opened this issue Oct 23, 2023 · 2 comments · Fixed by #36
Assignees
@dlubitz

Comments

@dlubitz
Copy link
Contributor

dlubitz commented Oct 23, 2023 •
edited
Loading 

- $renderingMode = $context->getCurrentRenderingMode();
+ $renderingMode = $this->renderingModeService->findByCurrentUser();
@dlubitz dlubitz mentioned this issue Oct 23, 2023
Closed
9 tasks
@dlubitz dlubitz self-assigned this Oct 23, 2023
@mhsdesign
Copy link
Member

Hmm the ContentContext was initially marked as internal (at least $node->getContext() declared it.

I would rather focus on more critical things like the Node::* methods ;)

@dlubitz
Copy link
Contributor Author

dlubitz commented Oct 23, 2023

I would rather focus on more critical things like the Node::* methods ;)

Sure, can you provide an issue with the regarding methods and their replacements?

@dlubitz dlubitz mentioned this issue Nov 1, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done ✅ in Neos 9.0 Release Board Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlubitz dlubitz

Labels
None yet
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TASK Refactor ContentContext methods neos/rector
2 participants
@dlubitz @mhsdesign