Critical migrations

[mhsdesign]

• NodeType::getName was removed !!! Remove NodeType::getName  neos-development-collection#4560
  • migrate ${node.nodeType.name} to ${node.nodeTypeName.value} (not 100% equivalent but should mostly do)
  • migrate $nodeType->getName() to $nodeType->name->value
• Rector rule to discourage / warn about path usage in Fusion #33
• warn about q(node).property('_path') and ${node.path} (the latter wont work either way) #34
• ContentContext::getCurrentRenderingMode to RenderingModeService::findByCurrentUser #31
• BUG: Rector migration for usage of node.parent doesn't work #29
• Remove NodeTypeManager from NodeType #35
• Rename _hiddenBeforeDateTime and _hiddenAfterDateTime in Fusion #41

[ahaeslich]

Ah I love it 💖. Had also tought about collecting those todos in an issue 😄

[dlubitz]

@mhsdesign Could you more explain the required path replacements for fusion?

I already found a rector migration ${node.path} => ${Neos.Node.path(node)}:

rector/tests/ContentRepository90/Rules/FusionNodePathRector/Fixture/some_file.fusion.inc

Line 8 in 618a7fd

attributes = ${node.path || documentNode.path}

Is this already done? Or is the migration outdated?

[mhsdesign]

okay i see, but we should also migrate q(node).property('_path') i like to abolish this syntax neos/neos-development-collection#4208