Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Rector migration for usage of node.parent doesn't work #29

Closed
Tracked by #25
ahaeslich opened this issue Oct 8, 2023 · 5 comments · Fixed by #30 or #37
Closed
Tracked by #25

BUG: Rector migration for usage of node.parent doesn't work #29

ahaeslich opened this issue Oct 8, 2023 · 5 comments · Fixed by #30 or #37
Assignees
@dlubitz

Comments

@ahaeslich
Copy link
Member

  • It will generate comments for lines that are using flow query operations like parent() or parents()
  • The comment says You may need to rewrite "VARIABLE.parent" to Neos.NodeAccess.findParent(VARIABLE). But I found no matching eel helper.
@ahaeslich ahaeslich mentioned this issue Oct 8, 2023
Closed
9 tasks
@dlubitz
Copy link
Contributor

dlubitz commented Oct 22, 2023

Good catch! Maybe someone of the experts can tell us what the correct replacement is?
/cc @mhsdesign @mficzel @bwaidelich

@mficzel
Copy link
Member

mficzel commented Oct 22, 2023

As I see from my cellphone flowQuery “parent”|”parents” is implemented. This migration might be not needed at all.

@dlubitz
Copy link
Contributor

dlubitz commented Oct 22, 2023

It's actually not FlowQuery it was the removed getter of the Node.

@mficzel
Copy link
Member

mficzel commented Oct 22, 2023

How about converting that to q(node).parent().get(0)

@dlubitz dlubitz mentioned this issue Oct 23, 2023
Merged
@dlubitz dlubitz moved this from Todo to Under Review 👀 in Neos 9.0 Release Board Oct 23, 2023
@dlubitz dlubitz self-assigned this Oct 23, 2023
@github-project-automation github-project-automation bot moved this from Under Review 👀 to Done ✅ in Neos 9.0 Release Board Oct 27, 2023
kdambekalns added a commit that referenced this issue Nov 1, 2023
@kdambekalns
BUGFIX: No longer warn for node.parents()
2975a9f 
Fixes #29 (the first item)
@kdambekalns
Copy link
Member

It still warns about q(node).parents()…

@kdambekalns kdambekalns reopened this Nov 1, 2023
@kdambekalns kdambekalns mentioned this issue Nov 1, 2023
Merged
kdambekalns added a commit that referenced this issue Nov 1, 2023
@kdambekalns
BUGFIX: No longer warn for node.parents() or similar code
76b1502 
Fixes #29 (the first item)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlubitz dlubitz

Labels
None yet
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
4 participants
@kdambekalns @mficzel @ahaeslich @dlubitz