-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! Remove NodeType::getName
#4560
Comments
@kitsunet pointed out that we need a rector rule for
|
6 tasks
github-project-automation
bot
moved this from Under Review 👀
to Done ✅
in Neos 9.0 Release Board
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NodeType getName(): string
is in the Neos 9 deprecated (and will be eventually removed?), but its replacementpublic readonly NodeTypeName $name
is not accessible via fusion. Calling ${nodeType.name.value} will actually invoke the getter!A migration phase for fusion code will thus be not possible. If we release both methods with Neos 9 we will not really be able to remove either of them conveniently and there will be no migration phase.
In slack we (@bwaidelich and @nezaniel) discussed that it would make more sense to remove
getName
now and write migrations for it.The text was updated successfully, but these errors were encountered: