Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! Remove NodeType::getName #4560

Closed
mhsdesign opened this issue Sep 25, 2023 · 1 comment · Fixed by #4562
Closed

!!! Remove NodeType::getName #4560

mhsdesign opened this issue Sep 25, 2023 · 1 comment · Fixed by #4562

Comments

@mhsdesign
Copy link
Member

NodeType getName(): string is in the Neos 9 deprecated (and will be eventually removed?), but its replacement public readonly NodeTypeName $name is not accessible via fusion. Calling ${nodeType.name.value} will actually invoke the getter!

A migration phase for fusion code will thus be not possible. If we release both methods with Neos 9 we will not really be able to remove either of them conveniently and there will be no migration phase.

In slack we (@bwaidelich and @nezaniel) discussed that it would make more sense to remove getName now and write migrations for it.

@mhsdesign
Copy link
Member Author

@kitsunet pointed out that we need a rector rule for node.nodeType.name

Do we have a rector rule for node.nodeType.name because that would have to be adapted then? otherwise it could very much make sense to have one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant