TASK: Adjust migration for renderingMode.isEdit
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Will be ready to review after neos/neos-development-collection#4505 |
mficzel
force-pushed
the
90/adjustMigrationForUserInterfaceMode
branch
3 times, most recently
from
b154abd to
81939fa
Compare
the migration previously adjusted the code to a now deprecated eel helper. In pr neos/neos-development-collection#4505 the renderingMode is introduced as global fusionValue which made an adjustment in the rector necessary. `(node|documentNode|site).context.inBackend` is now migrated to `renderingMode.isEdit` `(node|documentNode|site).context.live` is now migrated to `!renderingMode.isEdit` In cases where it cannot be determined wether a node is affected by the `context` operation a comment is added as before.
mficzel
force-pushed
the
90/adjustMigrationForUserInterfaceMode
branch
from
81939fa to
7f4b7b6
Compare
ahaeslich
approved these changes
Sep 17, 2023
|
@mficzel just checking whether only the description is wrong: we did agree to remove the |
|
@bwaidelich right Description is outdated live becomes !isEdit |
6 tasks
mhsdesign
changed the title
renderingMode.isEdit
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the migration previously adjusted the code to a now deprecated eel helper. In pr neos/neos-development-collection#4505 the userInterfaceMode is introduced as global fusionValue which made an adjustment in the rector necessary.
(node|documentNode|site).context.inBackendis now migrated torenderingMode.isEdit(node|documentNode|site).context.liveis now migrated to!renderingMode.isEditIn cases where it cannot be determined wether a node is affected by the
contextoperation a comment is added as before.Relates: neos/neos-development-collection#4086