Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Refactor node properties #39

Merged
merged 3 commits into from
Nov 5, 2023
Merged

TASK: Refactor node properties #39

merged 3 commits into from
Nov 5, 2023

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Nov 2, 2023

Fixes #34

@dlubitz dlubitz force-pushed the task/node-properties branch from b7987a0 to 538b9e7 Compare November 3, 2023 08:44
@kdambekalns kdambekalns changed the title TASK Refactor node properties TASK: Refactor node properties Nov 3, 2023
kdambekalns
kdambekalns approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what src/Generic/Rules/FusionFlowQueryNodePropertyToWarningCommentRector.php and why it contains the warning comment about _autoCreated.

Other than that 👍 by 👀

@dlubitz
Copy link
Contributor Author

dlubitz commented Nov 3, 2023

https://github.com/neos/rector/pull/39/files#diff-43a3b10ea18a97f4dbea0b1899402eceb50f51d69cc65594cf8c833f25bd340aR28-R29

This is an example/CodeSample used to create documentation.

@ahaeslich ahaeslich merged commit 255ab72 into main Nov 5, 2023
2 checks passed
@dlubitz dlubitz deleted the task/node-properties branch January 3, 2024 19:04
@dlubitz dlubitz mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahaeslich ahaeslich ahaeslich approved these changes

@kdambekalns kdambekalns kdambekalns approved these changes

@mhsdesign mhsdesign Awaiting requested review from mhsdesign

@kitsunet kitsunet Awaiting requested review from kitsunet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warn about q(node).property('_path') and ${node.path} (the latter wont work either way)
3 participants
@dlubitz @kdambekalns @ahaeslich