TASK: Update to use swiftmailer/swiftmailer version 6 #14
Conversation
kdambekalns
force-pushed
the
task/swiftmailer-6
branch
from
b0bf4ce to
e876572
Compare
|
💀 This has not been tested yet… |
|
✅ Works for me with |
| @@ -53,17 +53,17 @@ Here is an example: | |||
|
|
|||
| .. code-block:: php | |||
|
|
|||
| $mail = new \Neos\SwiftMailer\Message(); | |||
| $mail = new \Neos\SwiftMailer\Message(); | |||
There was a problem hiding this comment.
TIL, we have a separate RTD page for this package (https://swiftmailer-for-flow.readthedocs.io/en/latest/#installation) - is that really necessary? I would recommend moving the .rst as .md to the root and close that RTD page.
There was a problem hiding this comment.
Well, having all documentation for "our packages" in the same format seems like a good idea. It can surely be made more discoverable, by the (upcoming) https://docs.neos.io/cms/references as well as a README (which I just added) that mentions the documentation.
|
Uuuh, what have I done :/ @kdambekalns why did you add the interface checks: https://github.com/neos/swiftmailer/pull/14/files#diff-e2bee996df2ca8c9e00358deaa5830efR47 and https://github.com/neos/swiftmailer/pull/14/files#diff-e2bee996df2ca8c9e00358deaa5830efR57. Just to have the return type annotation? If I remove the checks and the return type annotation, it works again. |
|
Yes, added the return type and then added the checks. But obviously that doesn't make sense, since that interface is our own… |
No description provided.