-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced memory footprint, skin tones and more #10
Open
COM8
wants to merge
23
commits into
neosmart:master
Choose a base branch
from
UWPX:merge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unicode 12.0
I'd love to see this PR merged, especially because of the skin tone and component emoji on their own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
string
to enum for the Emoji groupstatic readonly
SkinTones
propertyHasGlyph
to be also valid for multi code point Emoji like "🧑🏼" or "✋🏼".AnimalsAndNature
orPeopleAndBody
)Documentation:
I updated the
README.md
documentation for the newSingleEmoji
attributes.WARNING: It still has my "fork from" header in it. I will remove it as soon this PR is ready to be merged.
SkinTone[] SkinTones
: A list ofSkinTone
objects that represent the current emoji. Example:{ SkinTone.NONE }
for "😀" ,{ SkinTone.DARK }
for "👨🏿⚕️" and{ SkinTone.DARK, SkinTone.MEDIUM }
for "🧑🏿🤝🧑🏽". They are in the same order like in the definition of the emoji (Sequence
).SkinTone[] NoSkinTones
: If the emoji does not has a specific skin tone (aka. yellow)SkinTones
points to this list.Group Group
: TheGroup
of the emoji. Example:SMILEYS_AND_EMOTION
for "😀" andPEOPLE_AND_BODY
for "👨🏿⚕️"string Subgroup
: The subgroup name of the emoji. Example:"face-smiling"
for "😀" and"person-role"
for "👨🏿⚕️"bool HasGlyph
: Is there a glyph for the emoji defined in theSegoe UI Emoji
font.