Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced memory footprint, skin tones and more #10

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

COM8
Copy link
Contributor

@COM8 COM8 commented Apr 14, 2019

Changes:

  • Reduced the memory footprint by switching from string to enum for the Emoji group
  • Reduced the memory footprint by storing all Emoji subgroups as static readonly
  • Added a SkinTones property
  • Updated the HasGlyph to be also valid for multi code point Emoji like "🧑🏼" or "✋🏼".
  • Added Windows specific Emoji ("🐱‍👤", "🐱‍🏍", "🐱‍💻", "🐱‍🐉", "🐱‍👓" and "🐱‍🚀")
  • Added lists for all Emoji groups (e.g. AnimalsAndNature or PeopleAndBody)
  • For all changes I used my Emoji-List-Parser so you might update your parser to be capable supporting these features😉

Documentation:

I updated the README.md documentation for the new SingleEmoji attributes.
WARNING: It still has my "fork from" header in it. I will remove it as soon this PR is ready to be merged.

  • SkinTone[] SkinTones: A list of SkinTone objects that represent the current emoji. Example: { SkinTone.NONE } for "😀" , { SkinTone.DARK } for "👨🏿‍⚕️" and { SkinTone.DARK, SkinTone.MEDIUM } for "🧑🏿‍🤝‍🧑🏽". They are in the same order like in the definition of the emoji (Sequence).
  • SkinTone[] NoSkinTones: If the emoji does not has a specific skin tone (aka. yellow) SkinTones points to this list.
  • Group Group: The Group of the emoji. Example: SMILEYS_AND_EMOTION for "😀" and PEOPLE_AND_BODY for "👨🏿‍⚕️"
  • string Subgroup: The subgroup name of the emoji. Example: "face-smiling" for "😀" and "person-role" for "👨🏿‍⚕️"
  • bool HasGlyph: Is there a glyph for the emoji defined in the Segoe UI Emoji font.

@sunkhaskasis
Copy link
Contributor

I'd love to see this PR merged, especially because of the skin tone and component emoji on their own.

@mqudsi mqudsi mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants