feat: reenabled import checking rules (eslint-plugin-import) (#197)

* feat: reenabled import checking rules (eslint-plugin-import) Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org> * refactor: enable eslint-plugin-import TS support Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org> * fix: add eslint-import-resolver-typescript as a dep Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org> * refactor: cleanup dependents-data Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org> --------- Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
neostandard · Dec 9, 2024 · 629e936 · 629e936
1 parent cb93f15
commit 629e936
Show file tree

Hide file tree

Showing 7 changed files with 295 additions and 15 deletions.
diff --git a/.knip.jsonc b/.knip.jsonc
@@ -4,6 +4,9 @@
     "index.js",
     "index.d.ts"
   ],
+  "ignoreDependencies": [
+    "eslint-import-resolver-typescript"
+  ],
   "ignore": [
     "test/should-*/**/*",
     "test/ts-extension-eslint.config.mjs"

diff --git a/README.md b/README.md
@@ -159,6 +159,7 @@ module.exports = require('neostandard')({
 #### List of exported plugins
 
 * `@stylistic` - export of [`@stylistic/eslint-plugin`](https://npmjs.com/package/@stylistic/eslint-plugin)
+* `import` - export of [`eslint-plugin-import`](https://npmjs.com/package/eslint-plugin-import)
 * `n` - export of [`eslint-plugin-n`](https://npmjs.com/package/eslint-plugin-n)
 * `promise` - export of [`eslint-plugin-promise`](https://npmjs.com/package/eslint-plugin-promise)
 * `react` - export of [`eslint-plugin-react`](https://npmjs.com/package/eslint-plugin-react)
@@ -179,7 +180,6 @@ export default [
 
 ## Missing for 1.0.0 release
 
-* Migrate `eslint-plugin-import` rules from `standard`: [#15](https://github.com/neostandard/neostandard/issues/15)
 * Investigate a dedicated `neostandard` runner: [#33](https://github.com/neostandard/neostandard/issues/33) / [#2](https://github.com/neostandard/neostandard/issues/2)
 
 Full list in [1.0.0 milestone](https://github.com/neostandard/neostandard/milestone/1)
@@ -203,11 +203,6 @@ Full list in [1.0.0 milestone](https://github.com/neostandard/neostandard/milest
 * [`dot-notation`](https://eslint.org/docs/rules/dot-notation) – *deactivated* – clashes with the [`noPropertyAccessFromIndexSignature`](https://www.typescriptlang.org/tsconfig#noPropertyAccessFromIndexSignature) check in TypeScript
 * [`n/no-deprecated-api`](https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/no-deprecated-api.md) – *changed* – changed to `warn` instead of `error` as they are not urgent to fix
 
-### Missing bits
-
-* Some plugins are not yet supporting ESLint 9 or flat configs and has thus not yet been added. These are:
-  - `eslint-plugin-import`
-
 ## Config helper
 
 You can use the provided CLI tool to generate a config for you:

diff --git a/index.js b/index.js
@@ -10,6 +10,10 @@ module.exports.plugins = /** @type {const} */ ({
   get '@stylistic' () {
     return require('@stylistic/eslint-plugin')
   },
+  get import () {
+    // @ts-ignore
+    return require('eslint-plugin-import')
+  },
   get n () {
     return require('eslint-plugin-n')
   },

diff --git a/lib/configs/base.js b/lib/configs/base.js
@@ -1,6 +1,8 @@
 'use strict'
 
 const globals = require('globals')
+// @ts-ignore
+const eslintPluginImport = require('eslint-plugin-import')
 const eslintPluginN = require('eslint-plugin-n')
 // @ts-ignore
 const eslintPluginPromise = require('eslint-plugin-promise')
@@ -21,8 +23,7 @@ module.exports = /** @satisfies {import('eslint').Linter.Config} */ ({
   },
 
   plugins: {
-    // TODO: Replace with https://github.com/un-ts/eslint-plugin-import-x, but do it in a way that works for the TS-config as well: https://github.com/un-ts/eslint-plugin-import-x?tab=readme-ov-file#typescript
-    // 'import',
+    import: eslintPluginImport,
     n: eslintPluginN,
     promise: eslintPluginPromise,
   },
@@ -149,12 +150,12 @@ module.exports = /** @satisfies {import('eslint').Linter.Config} */ ({
     'valid-typeof': ['error', { requireStringLiterals: true }],
     yoda: ['error', 'never'],
 
-    // 'import/export': 'error',
-    // 'import/first': 'error',
-    // 'import/no-absolute-path': ['error', { 'esmodule': true, 'commonjs': true, 'amd': false }],
-    // 'import/no-duplicates': 'error',
-    // 'import/no-named-default': 'error',
-    // 'import/no-webpack-loader-syntax': 'error',
+    'import/export': 'error',
+    'import/first': 'error',
+    'import/no-absolute-path': ['error', { esmodule: true, commonjs: true, amd: false }],
+    'import/no-duplicates': 'error',
+    'import/no-named-default': 'error',
+    'import/no-webpack-loader-syntax': 'error',
 
     // TODO: Should only be active for server side scripts
     'n/handle-callback-err': ['error', '^(err|error)$'],

diff --git a/lib/ts.js b/lib/ts.js
@@ -88,6 +88,12 @@ function typescriptify (configs, options) {
       // @ts-ignore - Plugin type mismatch between typescript-eslint and ESLint
       '@typescript-eslint': plugin,
     },
+    settings: {
+      'import/resolver': {
+        typescript: true,
+        node: true,
+      },
+    },
     rules: {
       ...deactivatedRules,
       ...replacementRules,