Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add nvim_win_hide #110

Closed
wants to merge 1 commit into from
Closed

api: add nvim_win_hide #110

wants to merge 1 commit into from

Conversation

glepnir
Copy link
Member

@glepnir glepnir commented Mar 29, 2021

cc @zchee

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #110 (422e001) into master (ee5cbe9) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #110     +/-   ##
========================================
- Coverage    63.2%   63.2%   -0.1%     
========================================
  Files          14      14             
  Lines        2085    2087      +2     
========================================
  Hits         1319    1319             
- Misses        631     633      +2     
  Partials      135     135             
Flag Coverage Δ
linux-1.14 63.1% <0.0%> (-0.1%) ⬇️
linux-1.15 63.1% <0.0%> (-0.1%) ⬇️
linux-1.16 63.1% <0.0%> (+<0.1%) ⬆️
macos-1.14 63.1% <0.0%> (-0.1%) ⬇️
macos-1.15 63.1% <0.0%> (-0.1%) ⬇️
macos-1.16 63.1% <0.0%> (-0.1%) ⬇️
windows-1.14 62.4% <0.0%> (+<0.1%) ⬆️
windows-1.15 62.4% <0.0%> (-0.1%) ⬇️
windows-1.16 62.4% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nvim/api.go 38.4% <0.0%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5cbe9...422e001. Read the comment docs.

@zchee
Copy link
Member

zchee commented Mar 29, 2021

@glepnir Thanks for PR.
but, I developed on #109, and needs testcase both PRs.
If you can write testcase for nvim_hide_win, I'll fix my PR about exclude nvim_hide_win.
What do you think about it?

@glepnir
Copy link
Member Author

glepnir commented Mar 29, 2021

sure write it tomorrow

@zchee
Copy link
Member

zchee commented Apr 11, 2021

@glepnir any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants