Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgpack/rpc: export ErrClosed and ErrInternal #72

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Conversation

zchee
Copy link
Member

@zchee zchee commented Jun 10, 2020

Export ErrClosed and ErrInternal for can handles rpc error type on the package user's side.

@zchee zchee requested a review from justinmk June 10, 2020 16:21
@zchee zchee self-assigned this Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   56.10%   56.10%           
=======================================
  Files          11       11           
  Lines        2636     2636           
=======================================
  Hits         1479     1479           
  Misses       1021     1021           
  Partials      136      136           
Impacted Files Coverage Δ
msgpack/rpc/endpoint.go 61.24% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e72716...3f86690. Read the comment docs.

@zchee zchee merged commit e544052 into master Jun 25, 2020
@zchee zchee deleted the msgpack-export-error branch June 25, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants