-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename sumneko_lua -> lua_ls #2439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dundargoc
reviewed
Feb 6, 2023
glepnir
approved these changes
Feb 7, 2023
glepnir
reviewed
Feb 7, 2023
glepnir
reviewed
Feb 7, 2023
Moved the deprecation to |
LGTM |
glepnir
reviewed
Feb 8, 2023
justinmk
approved these changes
Feb 9, 2023
teto
approved these changes
Feb 11, 2023
could you rename it to |
folke
pushed a commit
to folke/neodev.nvim
that referenced
this pull request
Feb 12, 2023
AndresMpa
added a commit
to AndresMpa/mu-vim
that referenced
this pull request
Feb 12, 2023
Since sumneko_lua have renamed to lua_ls I'm moving this to follow last standard of lspconfig Ref: neovim/nvim-lspconfig#2439
polyzen
added a commit
to polyzen/dotfiles
that referenced
this pull request
Feb 12, 2023
ezradiniz
added a commit
to ezradiniz/dotfiles
that referenced
this pull request
Feb 13, 2023
askoufis
added a commit
to askoufis/dotfiles
that referenced
this pull request
Feb 13, 2023
- The `sumneko_lua` repo is under a new org and has been renamed to `lua_language_server`. `nvim-lspconfig` and `mason` have already been updated to reflect this. - neovim/nvim-lspconfig#2439
budimanjojo
added a commit
to budimanjojo/nix-config
that referenced
this pull request
Feb 20, 2023
fky2015
added a commit
to fky2015/dotfiles
that referenced
this pull request
Feb 21, 2023
victorblasco
added a commit
to factorialco/factorial-dotfiles
that referenced
this pull request
Feb 22, 2023
fcsonline
pushed a commit
to factorialco/factorial-dotfiles
that referenced
this pull request
Feb 23, 2023
Springok
added a commit
to Springok/wconfig
that referenced
this pull request
Feb 23, 2023
djpowers
added a commit
to djpowers/dotfiles
that referenced
this pull request
Feb 23, 2023
stephencottontail
added a commit
to stephencottontail/magic-kit
that referenced
this pull request
Feb 25, 2023
solarshado
added a commit
to solarshado/lspcontainers.nvim
that referenced
this pull request
Mar 8, 2023
solarshado
added a commit
to solarshado/lspcontainers.nvim
that referenced
this pull request
Mar 8, 2023
minghongx
added a commit
to minghongx/nvim
that referenced
this pull request
Mar 14, 2023
emilmgeorge
added a commit
to emilmgeorge/dotfiles
that referenced
this pull request
Mar 17, 2023
Lua LSP sumneko_lua has been renamed to lua_ls neovim/nvim-lspconfig#2439
NavidSassan
added a commit
to NavidSassan/dot_nvim
that referenced
this pull request
Mar 22, 2023
keep-cloud-tr
added a commit
to keep-cloud-tr/pkgbuilds
that referenced
this pull request
Mar 29, 2023
Alvis-73
added a commit
to alvisLu/dotfiles
that referenced
this pull request
Apr 2, 2023
mauroporras
added a commit
to mauroporras/dotfiles
that referenced
this pull request
Apr 23, 2023
erikreinert
pushed a commit
to lspcontainers/lspcontainers.nvim
that referenced
this pull request
Jun 3, 2023
* Rename "sumneko_lua" to "lua_ls" as per neovim/nvim-lspconfig#2439 * Rename "sumneko" -> "lua_ls" everywhere else too
fky2015
added a commit
to fky2015/dotfiles
that referenced
this pull request
Jun 4, 2023
swoh816
added a commit
to swoh816/Neovim-from-scratch
that referenced
this pull request
Jul 11, 2023
sumneko_lua is deprecated as of the following commit: neovim/nvim-lspconfig#2439
swoh816
added a commit
to swoh816/Neovim-from-scratch
that referenced
this pull request
Jul 11, 2023
sumneko_lua is deprecated as of the following commit: neovim/nvim-lspconfig#2439
wincent
added a commit
to wincent/wincent
that referenced
this pull request
Aug 1, 2023
They say you gotta switch to lua_ls. And so it is. I believe it is just a name-change with no significant API changes: - neovim/nvim-lspconfig#2439
taylorskalyo
added a commit
to taylorskalyo/pkgbuilds
that referenced
this pull request
Sep 25, 2023
3 tasks
kuntau
added a commit
to kuntau/dotfiles
that referenced
this pull request
Jul 12, 2024
kuntau
added a commit
to kuntau/dotfiles
that referenced
this pull request
Jul 15, 2024
pchest
pushed a commit
to pchest/nvim-config
that referenced
this pull request
Sep 20, 2024
The lua language server from sumneko had changed its repo and created a new organizational repo. See also neovim/nvim-lspconfig#2439.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sumneko has moved lua-language-server to a new GitHub organization (@LuaLS), https://github.com/sumneko/lua-language-server now redirects to https://github.com/LuaLS/lua-language-server
In terms of popularity, there are no competing language servers named
lua-language-server
, and the package is namedlua-language-server
on repologylspconfig currently doesn't have a rename policy for servers,
require("lspconfig").sumneko_lua.setup
will still work as before, just with a warning saying it has been renamed tolua_language_server
. When this warning should be changed to a hard error is up for discussion.