Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for the other nim language server #2581

Merged
merged 2 commits into from
May 2, 2023
Merged

feat: Add support for the other nim language server #2581

merged 2 commits into from
May 2, 2023

Conversation

marcusramberg
Copy link
Contributor

name: Pull Request
about: Submit a pull request
title: ''

glepnir
glepnir requested changes May 1, 2023
View reviewed changes
Copy link
Member

@glepnir glepnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change file name nim-langserver to nim_ls or nim_langserver

lua/lspconfig/server_configurations/nim-langserver.lua Outdated Show resolved Hide resolved
@marcusramberg marcusramberg force-pushed the feat/nim-langserver branch 3 times, most recently from c87cad1 to e12c35d Compare May 1, 2023 13:44
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Do not change server_configurations.md directly. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@marcusramberg
Copy link
Contributor Author

ok, something went terribly wrong here with a rebase, but I think it's all sorted now. 🙈

@marcusramberg marcusramberg requested a review from glepnir May 1, 2023 13:49
@marcusramberg
Copy link
Contributor Author

Thanks! Rolled that change into my PR and added it for nimls as well.

glepnir
glepnir reviewed May 2, 2023
View reviewed changes
lua/lspconfig/server_configurations/nim_langserver.lua Outdated

return {
default_config = {
cmd = { cmd },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmd = { cmd },
cmd = cmd,

@glepnir glepnir merged commit abd9bd6 into neovim:master May 2, 2023
@marcusramberg marcusramberg deleted the feat/nim-langserver branch May 2, 2023 13:30
@omentic omentic mentioned this pull request Dec 18, 2023
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glepnir glepnir glepnir requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusramberg @glepnir