refactor: improve get_clients_from_cmd_args #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably works, but not thoroughly tested yet |
improve the get_clients_from_cmd_args for better readability and consistency. - replace unnecessary dictionary-based approaches with array-based ones. - use the '#' to improve code readability. - use the '#' for an empty check.
sys9kdr
force-pushed
the
refactor/get_clients_from_cmd_args
branch
from
0ce86ef to
8d6048d
Compare
|
Manually, I confirmed that LspRestart and LspStop work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve the get_clients_from_cmd_args for better readability and consistency.