Skip to content

feat: update to tree-sitter 0.24 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ObserverOfTime
Copy link
Contributor

  • Add the new tree-sitter.json config file
  • Remove existing binding files
  • Run tree-sitter init to create them anew
    • Manually tweak a few of them
  • Run tree-sitter generate to update the grammar
  • Include Cargo.lock in versioning instructions
  • Update the main CI workflow
  • Introduce a new release workflow

@ObserverOfTime
Copy link
Contributor Author

ObserverOfTime commented Oct 20, 2024

There are no changes to parser.c this time so the failures likely stem from an internal tree-sitter change. 🤔

@clason
Copy link
Member

clason commented Oct 20, 2024

Could you please not make ALL THE CHANGES in a single PR.

@clason clason closed this Oct 20, 2024
@ObserverOfTime
Copy link
Contributor Author

All the changes, barring CI, come from running 2 commands.

@clason
Copy link
Member

clason commented Oct 20, 2024

So that's three separate sets of changes, no?

@ObserverOfTime
Copy link
Contributor Author

You will still have 30 changed files in one of the sets.

@clason
Copy link
Member

clason commented Oct 20, 2024

Yes but I can ignore those and not play "hunt the changes that will affect us".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants